Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing reviewer names in emails #17

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

abujeda
Copy link
Collaborator

@abujeda abujeda commented Dec 19, 2024

PR to fix missing reviewer first name in email templates when creating a new reviewer in the add reviewer flow.

This is just a fix for the issue.

Unit tests need to be fixed for the new code.

@abujeda abujeda requested a review from jp-tosca December 19, 2024 15:29
@abujeda
Copy link
Collaborator Author

abujeda commented Dec 19, 2024

I fixed the broken tests.
But the new functionality is not tested yet.

@abujeda
Copy link
Collaborator Author

abujeda commented Dec 19, 2024

Added unit tests. We need to review, build, and deploy to TEST

@jp-tosca jp-tosca self-assigned this Jan 3, 2025
@jp-tosca jp-tosca merged commit c8b0dd1 into main Jan 7, 2025
1 check passed
@jp-tosca jp-tosca added Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) HPPRP Tasks associated with the Harvard Peer Pre-Review Program labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 14 FY25 Sprint 14 (2025-01-02 - 2025-01-15) HPPRP Tasks associated with the Harvard Peer Pre-Review Program Size: 30 A percentage of a sprint. 21 hours. (formerly size:33)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants